Conversation
aw-sync is still under development/preview, but UserConfig::default() unconditionally added it to the autostart module list on every platform. A stock install therefore ran aw-sync's daemon and created ~/ActivityWatchSync without the user ever opting into sync. Users who want sync can still enable aw-sync via the module settings; --sync-dir and AW_SYNC_DIR are unaffected. Closes ActivityWatch/activitywatch#1418 Git-Session-Id: 574f41a7-60fb-5a8b-98bd-6bb2ceb9651f
|
Git-Session-Id: 02af41ce-32e6-511c-b2fe-2404985addd8
|
@greptileai review |
🤖 AI code reviewRemoves the unconditional Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No thread-worthy findings. Advisory notes follow; they are retained without opening review threads. 1 advisory finding (summary-only, not scored)These P2 guard, heuristic, trade-off, or documentation claims are retained for judgment without opening review threads.
This is a How this was verified: static preflight: fix-commit + touched-files scan (rule 7) Files changed (2) — the diff as I read it
Reviewed Maintainer commands
|
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
Problem
A stock ActivityWatch install runs
aw-sync daemonfrom the very firstlaunch, even though the user never enabled sync. This creates
~/ActivityWatchSync/<uuid>/test.dbunprompted — seeActivityWatch/activitywatch#1418.
Root cause:
UserConfig::default()unconditionally pushesaw-sync(withdaemonargs) into the autostart module list on every platform.What changed
Removed the unconditional
aw-syncautostart entry fromUserConfig::default(). Sync is still under development/preview(ActivityWatch/aw-server-rust#667 (comment)), so it shouldn't run by default.
Users who want sync can still add
aw-syncvia the module settings; the--sync-dir/AW_SYNC_DIRoverrides and the documented default synclocation are unaffected by this change.
Closes ActivityWatch/activitywatch#1418
Related
A companion PR (ActivityWatch/aw-server-rust#667) proposed changing
aw-sync's default sync directory instead — closed per @ErikBjare's
feedback that
~/ActivityWatchSyncneeds to stay easy to find/pointSyncthing/Dropbox/rsync at. This PR fixes the actual root cause (autostart)
without touching the default directory.
Testing
cargo fmt --check,cargo clippy --all-targets,cargo checkall passlocally (icons/webui dist generated locally as placeholders to satisfy the
build — CI has the real prebuilt assets). The diff only removes 4 lines and
adds a comment, no logic branches touched elsewhere.