docs(build): explain where createUpdaterArtifacts is enabled - #264
TimeToBuildBob wants to merge 2 commits into
Conversation
…via env Git-Session-Id: 275d
|
| # TAURI_SIGNING_PRIVATE_KEY in the environment causes Tauri CLI to set | ||
| # bundle.createUpdaterArtifacts=true automatically. That flag is therefore | ||
| # absent from tauri.conf.json even though release builds produce .sig files. |
There was a problem hiding this comment.
The comment says Tauri CLI automatically enables
createUpdaterArtifacts, but the surrounding Makefile explicitly enables it by adding a --config override when TAURI_SIGNING_PRIVATE_KEY is defined. This may lead maintainers to assume that direct CLI builds receive the same override.
| # TAURI_SIGNING_PRIVATE_KEY in the environment causes Tauri CLI to set | |
| # bundle.createUpdaterArtifacts=true automatically. That flag is therefore | |
| # absent from tauri.conf.json even though release builds produce .sig files. | |
| # When TAURI_SIGNING_PRIVATE_KEY is present, the Makefile override above sets | |
| # bundle.createUpdaterArtifacts=true. That flag is therefore absent from | |
| # tauri.conf.json even though signed builds produce .sig files. |
Knowledge Base Used:
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Fixed in 9ced114 — comment now attributes the flag to the Makefile's --config override (using your suggested wording).
…e, not Tauri CLI Git-Session-Id: eef7feae-db2d-507e-944e-adff911c071a
|
@greptileai review |
🤖 AI code reviewThis PR adds a three-line comment to the Makefile's build target explaining that the bundle.createUpdaterArtifacts flag is injected via a --config override when TAURI_SIGNING_PRIVATE_KEY is set, and is therefore absent from tauri.conf.json. No functional code changes are made. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
tauri.conf.jsonhas nobundle.createUpdaterArtifactskey, yet release builds produce.sigupdater artifacts. The explanation is inMakefile: whenTAURI_SIGNING_PRIVATE_KEYis present in the environment, a--configoverride injects the flag at build time.Add a three-line comment on the
buildtarget so the config file is not misleading to anyone reading it in isolation.