Skip to content

fix(macos): keep foreground tracking when browser context fails #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimeToBuildBob wants to merge 6 commits into
base: master
Choose a base branch
from
+492 −199
Open

fix(macos): keep foreground tracking when browser context fails #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
acb3eca
fix(macos): rebase foreground reconciliation onto master
TimeToBuildBob Sep 15, 2026
8ac81d3
fix(macos): restore @main entry so two-file swiftc compiles
TimeToBuildBob Sep 15, 2026
9424b4f
fix(macos): drop stale same-window title callbacks and Safari AX titles
TimeToBuildBob Sep 16, 2026
f9377a9
fix(macos): release unused AXObserver when notification add fails
TimeToBuildBob Sep 16, 2026
90aad7f
fix(macos): drop unused AXObserver via ARC and isolate swift tests
TimeToBuildBob Sep 16, 2026
fe2f5c1
fix(macos): retry title-change observer after transient AX add failure
TimeToBuildBob Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.PHONY: build test package clean
.PHONY: build test test-swift package clean

MACOSX_DEPLOYMENT_TARGET ?= 12.0

Expand All @@ -11,13 +11,24 @@ build:

build-swift: aw_watcher_window/aw-watcher-window-macos

aw_watcher_window/aw-watcher-window-macos: aw_watcher_window/macos.swift
aw_watcher_window/aw-watcher-window-macos: aw_watcher_window/macos.swift aw_watcher_window/macos_state.swift
swiftc -target "$(shell uname -m)-apple-macosx$(MACOSX_DEPLOYMENT_TARGET)" $^ -o $@

test:
poetry run aw-watcher-window --help # Ensures that it at least starts
poetry run python -m pytest tests/
make typecheck
if [ "$(shell uname)" = "Darwin" ]; then \
make test-swift; \
fi

test-swift:
tmpdir=$$(mktemp -d) && \
trap 'rm -rf "$$tmpdir"' EXIT && \
swiftc -target "$(shell uname -m)-apple-macosx$(MACOSX_DEPLOYMENT_TARGET)" \
aw_watcher_window/macos_state.swift tests/macos_state_tests.swift \
-o "$$tmpdir/macos-state-tests" && \
"$$tmpdir/macos-state-tests"

typecheck:
poetry run mypy aw_watcher_window/ --ignore-missing-imports
Expand Down
Loading
Loading