Add unquantified check for vague answers to counting prompts - #42
Merged
royalpinto007 merged 4 commits intoSep 11, 2026
Merged
Conversation
|
Welcome, @HarshRajSinghania, and thanks for your first pull request to Agentrace. A quick look at CONTRIBUTING.md covers how things are set up and run here. I'll review this shortly. Ask anything in the thread if something is unclear. |
|
Nice work @HarshRajSinghania, this is merged. Good, focused change. Exactly the kind of thing Agentrace needs. If Agentrace is useful to you, a star goes a long way. Happy to see more from you whenever you have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
unquantifiedcheck that flags results which answer a counting/listing prompt with a vague quantifier and no countable output.Motivation
Fixes #41. A prompt such as "report every failing test as node ids" answered with "several hot paths worth investigating" currently produces no finding.
Implementation
check_unquantifiedinagentrace/checks.py:report every,how many,enumerate, etc.).lowseverity when the result still uses a vague quantifier (several,some,a few,many, ...).Registered next to the other checks in
CHECKS. README table updated.Testing
Ran locally:
Result: 45 passed.
New tests cover the issue's two acceptance cases: