Skip to content

fix(frontend): unify shouldIgnoreRowClick to shared utility in useTableManager #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quantum0uasar wants to merge 5 commits into
base: release/v0.100.2
Choose a base branch
from
+1 −10
Open

fix(frontend): unify shouldIgnoreRowClick to shared utility in useTableManager #4391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fbd710a
fix(frontend): use shared shouldIgnoreRowClick from useTableManager
Quantum0uasar May 20, 2026
cd25bce
fix(frontend): remove duplicate shouldIgnoreRowClick from navigationA…
Quantum0uasar May 20, 2026
ae4ee25
Merge branch 'release/v0.100.1' into fix/unify-shouldIgnoreRowClick-u…
ardaerzin May 22, 2026
8473593
fix(frontend): use @/oss alias for shouldIgnoreRowClick import path
Quantum0uasar May 24, 2026
4120cce
Merge branch 'release/v0.100.2' into fix/unify-shouldIgnoreRowClick-u…
ardaerzin May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions web/oss/src/components/EvaluationRunsTablePOC/actions/navigationActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type {MouseEvent} from "react"

import {message} from "@agenta/ui/app-message"
import {getDefaultStore} from "jotai"
Expand All @@ -23,14 +22,6 @@ const getUrlState = (): URLState => store.get(urlAtom) as URLState

const getActiveAppId = (): string | null => store.get(routerAppIdAtom)

export const shouldIgnoreRowClick = (event: MouseEvent<HTMLElement>) => {
const target = event.target as HTMLElement | null
if (!target) return false
const interactiveSelector =
"button, a, input, textarea, select, [role='button'], [role='menuitem'], [role='checkbox'], .ant-checkbox, .ant-checkbox-input, .ant-checkbox-inner, .ant-checkbox-wrapper, .ant-btn, .ant-select, .ant-dropdown-trigger"
return Boolean(target.closest(interactiveSelector))
}

interface NavigateToRunParams {
record: EvaluationRunTableRow
scope: "app" | "project"
Expand Down
2 changes: 1 addition & 1 deletion web/oss/src/components/EvaluationRunsTablePOC/components/EvaluationRunsTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import {
} from "@/oss/lib/onboarding"
import {useQueryParamState} from "@/oss/state/appState"

import {shouldIgnoreRowClick} from "../../actions/navigationActions"
import {shouldIgnoreRowClick} from "@/oss/components/InfiniteVirtualTable/hooks/useTableManager"
import {
evaluationRunsDeleteContextAtom,
evaluationRunsTableFetchEnabledAtom,
Expand Down