fix: use secondary delay for secondary subtitles - #182
Merged
Merged
Conversation
Contributor
Author
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mpv has separate timing settings for primary and secondary subtitles:
sub-delayfor the primary tracksecondary-sub-delayfor the secondary trackMpvacious currently uses
sub-delaywhen calculating the timing of bothtracks. When the two settings differ, the secondary subtitle is read at the
wrong time.
Example
Suppose the primary subtitle delay is 2 seconds and the secondary subtitle
delay is 1 second. Mpvacious currently shifts both tracks by 2 seconds, so the
secondary subtitle is off by 1 second.
After this change, the primary track is shifted by 2 seconds and the secondary
track by 1 second, matching what mpv displays.
Change
Use
secondary-sub-delaywhen reading secondary subtitle timestamps. Primarysubtitles continue to use
sub-delay.Tests
Added a test where the primary and secondary delays are different. The full
test suite passes with
luajit tests/run.lua.