allow to round values in CSVexporter - #5497
Open
Nathekip wants to merge 3 commits into
Open
Conversation
Nathekip
force-pushed
the
master
branch
3 times, most recently
from
July 21, 2026 10:46
25a9222 to
92ba4b8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5497 +/- ##
=========================================
Coverage 61.53% 61.53%
Complexity 14 14
=========================================
Files 2 2
Lines 78 78
Branches 4 4
=========================================
Hits 48 48
Misses 24 24
Partials 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR begins implementing issue #131’s request to let users control numeric rounding in CSV exports by introducing a new decimalPlacesCount parameter on CSVExporter and adjusting tests/configuration accordingly.
Changes:
- Added a
decimalPlacesCountconstructor parameter toCSVExporterand used it to round exported values in one output branch. - Updated
TestCSVExporter’s numeric-matching regex for the “fixed decimals” export. - Updated a Protelis test YAML to pass
intervalanddecimalPlacesCounttoCSVExporter.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| alchemist-loading/src/main/kotlin/it/unibo/alchemist/boundary/exporters/CSVExporter.kt | Adds exporter-level decimal rounding support via a new parameter and a rounding helper. |
| alchemist-loading/src/test/kotlin/it/unibo/alchemist/test/TestCSVExporter.kt | Updates the regex used to validate decimal formatting in exported data. |
| alchemist-incarnation-protelis/src/test/resources/testbase.yml | Exercises the new exporter parameters in a test configuration. |
Comment on lines
104
to
108
| when { | ||
| data.size <= 1 -> data.values.joinToString(" ") | ||
| data.size <= 1 -> | ||
| roundValues(data.values, decimalPlacesCount.toInt()).joinToString(" ") | ||
| // Labels and keys match | ||
| data.size == names.size && data.keys.containsAll(names) -> |
Member
There was a problem hiding this comment.
@Nathekip, add a test with multiple columns, please, and if that it goes red, apply a fix!
Thank you, let me know
DanySK
force-pushed
the
master
branch
20 times, most recently
from
July 27, 2026 19:52
212bdd4 to
7b19587
Compare
DanySK
force-pushed
the
master
branch
18 times, most recently
from
August 8, 2026 22:34
ef40806 to
65ae803
Compare
DanySK
force-pushed
the
master
branch
7 times, most recently
from
August 12, 2026 10:46
9c11dc4 to
d9063af
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially tackles the issue #131, specifically the ability for user to specify the amount of numbers they want after the decimal