Move consts and structs outside of program scope#4
Open
Roee-87 wants to merge 3 commits into
Open
Conversation
Roee-87
marked this pull request as ready for review
June 25, 2026 03:54
eranrund
approved these changes
Jun 25, 2026
eranrund
left a comment
eranrund
left a comment
Collaborator
There was a problem hiding this comment.
This looks good from what I can tell, and the unit test suite passes locally.
I'd like to experiment with using https://docs.leo-lang.org/language/layout#modules to clean this up since the multisig_core program is very long and messy at this point, I'll try it out when I have a chance.
Collaborator
|
I tried using leo modules to see if it helps clean up but its a very minor difference: 2286953 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leo v4.3.0 requires that structs and consts be declared outside of the program scope. This PR refactors the multisig core program code in order to comport with the those requirements.