ITS3: opt. staggering and fixes to alignment#15401
Open
f3sch wants to merge 1 commit into
Open
Conversation
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
requested review from
arossi81,
fgrosa,
mconcas,
sawenzel and
shahor02
as code owners
shahor02
reviewed
May 17, 2026
Collaborator
shahor02
left a comment
shahor02
left a comment
There was a problem hiding this comment.
Looks good (w/o gooing too deep), just 1 comment.
| if (reader.getInteractionRecord().isDummy()) { | ||
| continue; // No IR info was found | ||
| } | ||
| if (!lastIR.isDummy() && lastIR >= reader.getInteractionRecord()) { |
Collaborator
There was a problem hiding this comment.
Perhaps one should ask ITS HW experts if this will not clash with the calibration scan data (afaik, today they don't clusterize it, by in principle, they may). In such data the IRs are quite meaningless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.