Skip to content

MC/PWGEM: update DY config in OO#2356

Open
dsekihat wants to merge 2 commits into
AliceO2Group:masterfrom
dsekihat:master
Open

MC/PWGEM: update DY config in OO#2356
dsekihat wants to merge 2 commits into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat
Copy link
Copy Markdown
Contributor

@dsekihat dsekihat commented May 15, 2026 •
edited
Loading

MC/PWGEM: update DY config in OO

@dsekihat dsekihat requested a review from a team as a code owner May 15, 2026 16:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@dsekihat dsekihat changed the title MC/PWGEM: update DY generator in OO MC/PWGEM: update DY config in OO May 15, 2026
jackal1-66
jackal1-66 requested changes May 18, 2026
View reviewed changes
Comment thread MC/config/PWGEM/ini/GeneratorDYee_GapTriggered_Gap2_OO5360GeV.ini
@@ -0,0 +1,7 @@
[GeneratorExternal]
fileName = ${O2DPG_MC_CONFIG_ROOT}/MC/config/PWGEM/external/generator/Generator_pythia8_GapTriggered_DYll.C
Copy link
Copy Markdown
Collaborator

@jackal1-66 jackal1-66 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${O2DPG_MC_CONFIG_ROOT}/MC/config/PWGEM/external/generator/Generator_pythia8_GapTriggered_DYLL.C → there's a typo here

Copy link
Copy Markdown
Contributor Author

@dsekihat dsekihat May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jackal1-66 , thank you for looking into this. But, my files have "DYll" consistently. So, DYll is the correct name, not capital DYLL. Do I misunderstand your comment?

Copy link
Copy Markdown
Collaborator

@jackal1-66 jackal1-66 May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsekihat you can check directly in the master of O2DPG online: the only available file has capital LL. Any chance you have renamed it by mistake in your local copy?

Copy link
Copy Markdown
Contributor Author

@dsekihat dsekihat May 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, you are right. O2DPG master and my linux machine shows DYLL, but my mac shows DYll. I made this PR from my mac. Thank you for your comments.

jackal1-66
jackal1-66 approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jackal1-66 jackal1-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. In the end I see you're the only one using this file and the other files in O2DPG all contain the lowercase ll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackal1-66 jackal1-66 jackal1-66 approved these changes

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsekihat @jackal1-66