fix(mail): expunge source folder after IMAP move/spam/ham - #66
Open
ThomasMms23 wants to merge 1 commit into
Open
ThomasMms23 wants to merge 1 commit into
ThomasMms23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
move/spam/hamdidCOPY+\Deletedbut neverEXPUNGE.\Deleted, expunge the source folder (do_children=False), same pattern asdelete_mails_by_uid.copyis unchanged.Why
Spotted while drag-and-dropping mails in SOGo6-UI (
batch-actionmove). Same bug on any move, not only DnD.Note for review
Folder EXPUNGE removes every
\Deletedmessage in that folder, not only the moved UIDs. That already matches delete.UID EXPUNGEwould be narrower if we want it later.Test plan
tests/test_module/test_mail/test_moduleMail.py(move/spam/ham expunge, copy does not)