Skip to content

♻️ refactor(auth-microservice) [OTP]: dedupe OTP spec blocks for the Sonar quality gate (tests only) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuankCadavid merged 1 commit into from
Sep 12, 2026
Merged

♻️ refactor(auth-microservice) [OTP]: dedupe OTP spec blocks for the Sonar quality gate (tests only) #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 66 additions & 48 deletions auth-microservice/src/api/auth/auth.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,56 @@ const mockEmailConfig: EmailConfigDto = {
'<html><body><h1>Welcome {{firstName}}!</h1><p>Password: {{tempPassword}}</p></body></html>',
};

// Shared OTP/registration test builders (OTP-T-3, OTP-T-10) — collapse the
// repeated Cognito/email-service mock setup and delegate-rejection shape to
// control duplication on new code.
const mockOtpTokens = {
accessToken: 'mock-access-token',
idToken: 'mock-id-token',
refreshToken: 'mock-refresh-token',
expiresIn: 3600,
tokenType: 'Bearer',
};

const mockCognitoAuthenticationResult = {
AuthenticationResult: {
AccessToken: mockOtpTokens.accessToken,
IdToken: mockOtpTokens.idToken,
RefreshToken: mockOtpTokens.refreshToken,
ExpiresIn: mockOtpTokens.expiresIn,
TokenType: mockOtpTokens.tokenType,
},
};

const expectDelegatedRejection = (
call: () => Promise<unknown>,
error: unknown,
) => expect(call()).rejects.toBe(error);

// Happy-path registration mocks (validate config -> generate password ->
// validate password -> create Cognito user) shared by the OTP-T-10
// PASSWORDLESS_DOMAINS case; the pre-existing registration tests keep their
// own inline setup unchanged.
const mockRegisterUserHappyPath = (
cognitoSvc: CognitoService,
dynamicEmailSvc: DynamicEmailService,
passwordGenSvc: PasswordGeneratorService,
createUserResult: unknown,
tempPassword = 'TempPass123!',
) => {
jest.spyOn(dynamicEmailSvc, 'validateEmailConfig').mockReturnValue({
isValid: true,
errors: [],
});
jest
.spyOn(passwordGenSvc, 'generateSecurePassword')
.mockReturnValue(tempPassword);
jest
.spyOn(passwordGenSvc, 'validateCognitoPassword')
.mockReturnValue({ isValid: true, errors: [] });
jest.spyOn(cognitoSvc, 'createUser').mockResolvedValue(createUserResult);
};

describe('AuthService', () => {
let service: AuthService;
let httpService: HttpService;
Expand Down Expand Up @@ -839,22 +889,12 @@ describe('AuthService', () => {
emailConfig: mockEmailConfig,
};

jest.spyOn(dynamicEmailService, 'validateEmailConfig').mockReturnValue({
isValid: true,
errors: [],
});
jest
.spyOn(passwordGeneratorService, 'generateSecurePassword')
.mockReturnValue('TempPass123!');
jest
.spyOn(passwordGeneratorService, 'validateCognitoPassword')
.mockReturnValue({
isValid: true,
errors: [],
});
jest
.spyOn(cognitoService, 'createUser')
.mockResolvedValue(mockCreateUserResult);
mockRegisterUserHappyPath(
cognitoService,
dynamicEmailService,
passwordGeneratorService,
mockCreateUserResult,
);
jest.spyOn(cognitoService, 'isPasswordlessDomain').mockReturnValue(true);
jest.spyOn(dynamicEmailService, 'getEmailStats').mockReturnValue({
variableCount: 6,
Expand Down Expand Up @@ -1123,7 +1163,7 @@ describe('AuthService', () => {

jest.spyOn(cognitoService, 'startEmailOtp').mockRejectedValueOnce(error);

await expect(service.startEmailOtp(dto)).rejects.toBe(error);
await expectDelegatedRejection(() => service.startEmailOtp(dto), error);
expect(error.getResponse()).toMatchObject({
code: 'CHALLENGE_NOT_SUPPORTED',
});
Expand All @@ -1138,15 +1178,7 @@ describe('AuthService', () => {
code: '12345678',
session: 'session-value',
};
const cognitoResult = {
tokens: {
accessToken: 'mock-access-token',
idToken: 'mock-id-token',
refreshToken: 'mock-refresh-token',
expiresIn: 3600,
tokenType: 'Bearer',
},
};
const cognitoResult = { tokens: mockOtpTokens };

jest
.spyOn(cognitoService, 'verifyEmailOtp')
Expand All @@ -1173,24 +1205,12 @@ describe('AuthService', () => {
password: 'password123',
};

jest.spyOn(cognitoService, 'verifyEmailOtp').mockResolvedValueOnce({
tokens: {
accessToken: 'mock-access-token',
idToken: 'mock-id-token',
refreshToken: 'mock-refresh-token',
expiresIn: 3600,
tokenType: 'Bearer',
},
});
jest.spyOn(cognitoService, 'loginWithCustomPassword').mockResolvedValueOnce({
AuthenticationResult: {
AccessToken: 'mock-access-token',
IdToken: 'mock-id-token',
RefreshToken: 'mock-refresh-token',
ExpiresIn: 3600,
TokenType: 'Bearer',
},
});
jest
.spyOn(cognitoService, 'verifyEmailOtp')
.mockResolvedValueOnce({ tokens: mockOtpTokens });
jest
.spyOn(cognitoService, 'loginWithCustomPassword')
.mockResolvedValueOnce(mockCognitoAuthenticationResult);

const otpResult = await service.verifyEmailOtp(otpDto);
const passwordResult =
Expand All @@ -1210,11 +1230,9 @@ describe('AuthService', () => {
HttpStatus.UNAUTHORIZED,
);

jest
.spyOn(cognitoService, 'verifyEmailOtp')
.mockRejectedValueOnce(error);
jest.spyOn(cognitoService, 'verifyEmailOtp').mockRejectedValueOnce(error);

await expect(service.verifyEmailOtp(dto)).rejects.toBe(error);
await expectDelegatedRejection(() => service.verifyEmailOtp(dto), error);
});
});
});
Loading