🔧 fix(auth-microservice, cognito-triggers) [OTP pre-PROD]: destination mask derived from the request username (no unknown-user tell) - #42
Merged
Conversation
…nation mask from the submitted userName (design §13 m) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…on from the request username, never from Cognito's reply (design §13 m) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JuankCadavid
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-PROD hardening #2 (
docs/auth/center-email-code-login/prod-rollout-runbook.md, design §13 (m)).5a758fd):startEmailOtpnow returnscodeDeliveryDestination = maskEmail(username)computed locally and ignores Cognito'sChallengeParameters— for unknown users Cognito substitutes the username before invoking the triggers, so only the microservice can produce a mask identical to a real user's. 17 suites / 380 tests,tsc+ eslint clean. Swagger + README updated.76868c0): mask fromevent.userName(kept; already deployed to the TEST stack).No env/pool changes. Merge → Jenkins deploys TEST.
🤖 Generated with Claude Code