Skip to content

Allow editing request settings during active jobs - #69

Closed
Estebangmz666 wants to merge 1 commit into
AlmostReliable:1.21.1from
Estebangmz666:fix/issue-37-edit-request-settings
Closed

Allow editing request settings during active jobs#69
Estebangmz666 wants to merge 1 commit into
AlmostReliable:1.21.1from
Estebangmz666:fix/issue-37-edit-request-settings

Conversation

@Estebangmz666

Copy link
Copy Markdown

Issue Reference

#37
Annoying Lockout #37
Fixes #37

Proposed Changes

  • allowed the Amount to Stock and Batch Size fields to remain editable while a request is crafting or exporting
    • kept the resource slot locked while a job is active
    • preserved the active job unchanged
    • applied updated values only to subsequent batches
    • prevented an amount of zero from clearing the resource while its slot is locked
  • renamed locksRequest() to locksResourceSlot() to better describe its behavior
  • updated the guidebook and changelog to document the new behavior

Additional Context

  • ran gradlew build successfully
  • tested in-game using a multi-level lectern autocrafting chain
  • verified that the active job retained its original batch size
  • verified that updated values were applied to subsequent batches
  • verified that changing the stock target prevented unnecessary future batches
  • verified that entering zero during an active job did not clear the resource

The screenshots below show the amount being changed to zero during an active job and then returning to its previous value without removing the configured resource.
changeStockTo0
valueGoBack

@rlnt

rlnt commented Aug 26, 2026

Copy link
Copy Markdown
Member

This won't work with the pending amount calculations. It could actually lead to a lot of desync if changed multiple times. I was still a beginner when initially creating this mod. Requests are not immutable, which was a pretty bad decision looking back at it. I am planning to do a rewrite soon for modern versions and use better concepts. With immutable requests, we could schedule a new request to replace the old one as soon as the current job is finished.

I do not plan to push any more feature updates to the 1.21.1 version of this mod. Thanks for your contribution, but this won't be merged.

@rlnt rlnt closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Annoying Lockout

2 participants