Allow editing request settings during active jobs - #69
Closed
Estebangmz666 wants to merge 1 commit into
Closed
Conversation
Member
|
This won't work with the pending amount calculations. It could actually lead to a lot of desync if changed multiple times. I was still a beginner when initially creating this mod. Requests are not immutable, which was a pretty bad decision looking back at it. I am planning to do a rewrite soon for modern versions and use better concepts. With immutable requests, we could schedule a new request to replace the old one as soon as the current job is finished. I do not plan to push any more feature updates to the 1.21.1 version of this mod. Thanks for your contribution, but this won't be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Reference
#37
Annoying Lockout #37
Fixes #37
Proposed Changes
locksRequest()tolocksResourceSlot()to better describe its behaviorAdditional Context
gradlew buildsuccessfullyThe screenshots below show the amount being changed to zero during an active job and then returning to its previous value without removing the configured resource.

