feat: cancel-group and cancel-group-or-exit bindings - #591
Open
arnodirlam wants to merge 2 commits into
Open
Conversation
arnodirlam
commented
Aug 24, 2026
|
|
||
| local default_binds=tab:down,btab:up,change:top,ctrl-space:toggle,bspace:backward-delete-char/eof,ctrl-h:backward-delete-char/eof | ||
| local fzf_command fzf_flags fzf_preview debug_command tmp switch_group active_group_style fzf_pad fzf_min_height binds | ||
| local fzf_command fzf_flags fzf_preview debug_command tmp switch_group cancel_group cancel_group_or_exit |
Author
There was a problem hiding this comment.
I was actually thinking to make a local line for each variable. That would be easier to diff in the future. WDYT?
arnodirlam
commented
Aug 24, 2026
|
|
||
| # receive arguments | ||
| local pid=$1 header_lines=$2 active_group_style=$3 tmp_dir=$4 offset=$5 | ||
| local pid=$1 header_lines=$2 active_group_style=$3 tmp_dir=$4 action=$5 value=$6 |
Author
There was a problem hiding this comment.
Changes the signature of ftb-switch-group to ... action=$5 value=$6 so it's more generic.
value could instead be named arg as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #590.