Fix /play download popover keyboard focus behavior#1825
Open
CarlosFelipeOR wants to merge 3 commits into
Open
Conversation
Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
…rols Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix keyboard accessibility in the
/playDownload popover: focus now moves into the popover on open, Tab/Shift+Tab navigation is contained inside it, focus is restored on Escape/after. Download, and outside-click close no longer steals focusCI/CD Options
Exclude tests:
Regression jobs to run: