AM-963 news: include construction work etl#170
Draft
jjbeekman wants to merge 13 commits into
Draft
Conversation
Major defects repeatedly escaped the first implementation pass during the news ETL refactor because the ported construction-work path was initially characterized against synthetic single-entity fixtures instead of the real payload and rerun semantics.\n\nThis retrospective updates the Developer agent guidance so future ETL or persistence ports explicitly characterize real payload shape, multi-entity batches, disappearance and cleanup cases, and cross-command side effects early in the red-green cycle.\n\nObserved failure pattern in this work item:\n- synthetic project image payload masked the real nested image contract\n- single-project tests missed multi-project section persistence regressions\n- rerun and removal semantics for articles, project images, and child rows were discovered late through review\n- shared-loader side effects crossed command boundaries until explicitly characterized\n\nExpected outcome: fewer review rework loops on ETL ports and earlier focused regression tests for real payload and rerun behavior.
Follow-up cleanup to the ETL port characterization retrospective.\n\nThe previous retrospective commit accidentally duplicated the new guidance line in the Developer approach block. This commit removes the duplicate so the instruction is clear and correctly numbered.
jjbeekman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Affected services
Definition of done
make openapi-diff)make dev)make requirements)After PR created (and deployed on dev):
Other notes
GitHub Copilot was used in writing the code