Skip to content

AM-1079 contact: add first aid and safe spaces to pride map#214

Open
fhaver-amsterdam wants to merge 2 commits into
mainfrom
pride/am-1079-add-first-aid-safe-spaces
Open

AM-1079 contact: add first aid and safe spaces to pride map#214
fhaver-amsterdam wants to merge 2 commits into
mainfrom
pride/am-1079-add-first-aid-safe-spaces

Conversation

@fhaver-amsterdam

@fhaver-amsterdam fhaver-amsterdam commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Extends the contact service’s Pride map configuration by introducing new Pride layers (First Aid and Safe Space), including corresponding icons and test fixtures.

Changes:

  • Added FIRST_AID and SAFE_SPACE to Pride map data/layer/icon enums.
  • Introduced Pride mock GeoJSON fixtures for first aid and safe space, and updated view tests to exercise them.
  • Reused a shared first-aid icon path for both Kingsday and Pride.

Affected services

  • contact

Definition of done

  • API is backwards compatible (make openapi-diff)
  • Swagger UI up-to-date & tested (make dev)
    - [ ] Dependencies updated (make requirements)
    - [ ] Infrastructure config updated (aapp_azure_infra)
    - [ ] Loadtests for relevant endpoints (aapp_testing_loadtests)

After PR created (and deployed on dev):

  • Manual check on dev (o) e.g. use feature via Swagger or admin panel
  • Sanity check on test app (check that dev environment is selected)

Other notes

GitHub Copilot was used in writing the code

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the contact service’s Pride map configuration by introducing new Pride layers (First Aid and Safe Space), including corresponding icons and test fixtures.

Changes:

  • Added FIRST_AID and SAFE_SPACE to Pride map data/layer/icon enums.
  • Introduced Pride mock GeoJSON fixtures for first aid and safe space, and updated view tests to exercise them.
  • Reused a shared first-aid icon path for both Kingsday and Pride.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
contact/tests/views/test_service_views.py Extends Pride layer test cases and imports to include first aid + safe space.
contact/tests/mock_data/pride/first_aid.py Adds mock GeoJSON fixture for Pride first aid layer.
contact/tests/mock_data/pride/safe_space.py Adds mock GeoJSON fixture for Pride safe spaces.
contact/icons.py Adds first-aid and pride-safe-space SVG paths; switches away from the Kingsday-specific first-aid key.
contact/enums/pride_map.py Registers new Pride layers and icons (FIRST_AID, SAFE_SPACE).
contact/enums/kingsday_land.py Updates Kingsday first aid icon to reference the shared first-aid path.

Comment thread contact/tests/mock_data/pride/safe_space.py
Comment thread contact/enums/pride_map.py
@fhaver-amsterdam fhaver-amsterdam changed the title add first and safe spaces to pride map AM-1079 contact: add first aid and safe spaces to pride map Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants