AM-1079 contact: add first aid and safe spaces to pride map#214
Open
fhaver-amsterdam wants to merge 2 commits into
Open
AM-1079 contact: add first aid and safe spaces to pride map#214fhaver-amsterdam wants to merge 2 commits into
fhaver-amsterdam wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the contact service’s Pride map configuration by introducing new Pride layers (First Aid and Safe Space), including corresponding icons and test fixtures.
Changes:
- Added FIRST_AID and SAFE_SPACE to Pride map data/layer/icon enums.
- Introduced Pride mock GeoJSON fixtures for first aid and safe space, and updated view tests to exercise them.
- Reused a shared first-aid icon path for both Kingsday and Pride.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
contact/tests/views/test_service_views.py |
Extends Pride layer test cases and imports to include first aid + safe space. |
contact/tests/mock_data/pride/first_aid.py |
Adds mock GeoJSON fixture for Pride first aid layer. |
contact/tests/mock_data/pride/safe_space.py |
Adds mock GeoJSON fixture for Pride safe spaces. |
contact/icons.py |
Adds first-aid and pride-safe-space SVG paths; switches away from the Kingsday-specific first-aid key. |
contact/enums/pride_map.py |
Registers new Pride layers and icons (FIRST_AID, SAFE_SPACE). |
contact/enums/kingsday_land.py |
Updates Kingsday first aid icon to reference the shared first-aid path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the contact service’s Pride map configuration by introducing new Pride layers (First Aid and Safe Space), including corresponding icons and test fixtures.
Changes:
Affected services
Definition of done
make openapi-diff)make dev)- [ ] Dependencies updated (make requirements)- [ ] Infrastructure config updated (aapp_azure_infra)- [ ] Loadtests for relevant endpoints (aapp_testing_loadtests)After PR created (and deployed on dev):
Other notes
GitHub Copilot was used in writing the code