Fix CI typecheck blindspot - #440
Open
Peolite001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #425
Description
This PR introduces a dedicated type-checking gate (
tsc --noEmit) to our CI pipeline and resolves 9 previously undetected type errors in our test files.Previously, CI relied on
next buildfor type-checking, which only covers modules reachable from the application's build graph, creating a blind spot where test files were silently failing type checks.Changes included:
typecheckscript: Introduced"typecheck": "tsc --noEmit"topackage.json..github/workflows/ci.ymlbefore the build step.MetricsBar.test.tsx: Added missingreload,mutate, andpendingSettlementsproperties to the mockeduseAsyncreturn values.SettlementTable.test.tsx: Fixed DOM element typecasting by asserting queried nodes asHTMLElementso that@testing-library'swithinfunction compiles correctly.We adopted a "fix-then-gate" approach since there were only 9 errors across 2 files, allowing us to lock down the test file contracts immediately without needing exceptions or tsconfig exclusions.
Checklist
CHANGELOG.mdentry under the next## [x.y.z]section(see the Format note at the top of
CHANGELOG.md), or this PRis docs-only / test-only / internal tooling and doesn't change
user-facing behavior. (Note: This PR is test/tooling-only).