Skip to content

chore(deps-dev): patch the two advisories dependabot auto-dismissed - #45

Merged
AndresSaa merged 1 commit into
mainfrom
chore/patch-remaining-dev-advisories
Aug 8, 2026
Merged

chore(deps-dev): patch the two advisories dependabot auto-dismissed#45
AndresSaa merged 1 commit into
mainfrom
chore/patch-remaining-dev-advisories

Conversation

@AndresSaa

Copy link
Copy Markdown
Owner

What changed

nanoid 3.3.16 → 3.3.18 and brace-expansion 5.0.8 → 5.0.9 in the lockfile. Nothing else.

Both carried high-severity advisories with a patch available, and both are development-scoped, so Dependabot's auto-triage rules dismissed the alerts and never opened a pull request:

Package Advisory Vulnerable Patched Reached through
nanoid GHSA-2v37-7h3g-55p8 — infinite loop on zero size < 3.3.17 3.3.17 tsuppostcss
brace-expansion GHSA-rgw5-rvv9-x895 — DoS via unbounded intermediate arrays < 5.0.9 5.0.9 eslintminimatch

Dismissed is not fixed. The alert stopped being shown; the lockfile kept resolving the vulnerable version, and npm audit kept reporting it on every install.

Why npm update and not npm audit fix

npm audit fix would also have bumped mermaid and dompurify — which is precisely what #43 and #44 already do. Two pull requests editing the same lockfile entries is a conflict for no gain. Both patches here land inside the ranges their parents already declare, so naming the two packages is enough.

This PR and #43/#44 touch disjoint hunks and merge in any order.

How it was tested

npm update nanoid brace-expansion   → 6 insertions, 6 deletions, those two entries only
npm run lint                        → clean (tsc, eslint, prettier)
npm test                            → 69 passed (5 files)
npm audit                           → 2 high resolved; the 2 moderate left are #43/#44

brace-expansion sits under eslint's globbing and nanoid under the tsup build path, so lint and a full build-and-test are the two things that would have noticed a regression. Both are green.

Contract impact

None. Development dependencies only — neither package has ever been reachable from dist, and files ships dist, docs and CHANGELOG.md. No changelog entry: nothing observable changes for a consumer.

nanoid and brace-expansion both had high-severity advisories with a patch
available, but both are development-scoped, so Dependabot's auto-triage
dismissed them and never opened a pull request. Dismissed is not fixed: the
lockfile still resolved the vulnerable versions, and `npm audit` still said so
on every install.

Both patches land inside the ranges their parents already declare — postcss
pulls nanoid through tsup, minimatch pulls brace-expansion through eslint — so
this is `npm update` on those two names, not `npm audit fix`, which would also
have bumped mermaid and dompurify and collided with the two open Dependabot
pull requests that already do exactly that.
@AndresSaa
AndresSaa merged commit ba520a7 into main Aug 8, 2026
12 checks passed
@AndresSaa
AndresSaa deleted the chore/patch-remaining-dev-advisories branch August 8, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant