chore(deps-dev): patch the two advisories dependabot auto-dismissed - #45
Merged
Conversation
nanoid and brace-expansion both had high-severity advisories with a patch available, but both are development-scoped, so Dependabot's auto-triage dismissed them and never opened a pull request. Dismissed is not fixed: the lockfile still resolved the vulnerable versions, and `npm audit` still said so on every install. Both patches land inside the ranges their parents already declare — postcss pulls nanoid through tsup, minimatch pulls brace-expansion through eslint — so this is `npm update` on those two names, not `npm audit fix`, which would also have bumped mermaid and dompurify and collided with the two open Dependabot pull requests that already do exactly that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nanoid3.3.16 → 3.3.18 andbrace-expansion5.0.8 → 5.0.9 in the lockfile. Nothing else.Both carried high-severity advisories with a patch available, and both are development-scoped, so Dependabot's auto-triage rules dismissed the alerts and never opened a pull request:
nanoid< 3.3.17tsup→postcssbrace-expansion< 5.0.9eslint→minimatchDismissed is not fixed. The alert stopped being shown; the lockfile kept resolving the vulnerable version, and
npm auditkept reporting it on every install.Why
npm updateand notnpm audit fixnpm audit fixwould also have bumpedmermaidanddompurify— which is precisely what #43 and #44 already do. Two pull requests editing the same lockfile entries is a conflict for no gain. Both patches here land inside the ranges their parents already declare, so naming the two packages is enough.This PR and #43/#44 touch disjoint hunks and merge in any order.
How it was tested
brace-expansionsits under eslint's globbing andnanoidunder the tsup build path, so lint and a full build-and-test are the two things that would have noticed a regression. Both are green.Contract impact
None. Development dependencies only — neither package has ever been reachable from
dist, andfilesshipsdist,docsandCHANGELOG.md. No changelog entry: nothing observable changes for a consumer.