ci: group security updates the way version updates are grouped - #46
Merged
Conversation
`applies-to` defaults to version updates, so the existing catch-all group never applied to security advisories: those bypassed grouping and arrived as one pull request per package. One mermaid-cli upgrade landed as two of them, each a three-line lockfile edit, each carrying a full matrix run. The fix is a second group with the same membership and the other value, since a package with zero runtime dependencies has nothing to update here that is not dev tooling. Validated against the SchemaStore dependabot-2.0 schema, which is the only check available before the file reaches the default branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
.github/dependabot.ymlalready declares a catch-all group, so weekly dev-dependency bumps arrive as one pull request. Security advisories did not — #43 and #44 are two separate pull requests, three lockfile lines each, from a single@mermaid-js/mermaid-cliupgrade.That is not a Dependabot quirk.
applies-todefaults toversion-updates, and grouping applies only to what a group is declared to apply to:So the group was silently doing half its job.
The change
A second group with identical membership and the other value:
Both take everything, which is not laziness: a package that ships zero runtime dependencies has nothing in this manifest that is not dev tooling. The existing
ignoreentries fortypescriptand@types/nodeare untouched and still apply.Group names have to be unique, hence two names rather than one entry with two values.
How it was tested
The schema check is worth stating precisely, because
applies-tois the kind of key that is easy to put at the wrong nesting level. It resolves to/definitions/update/properties/groups/additionalProperties, i.e. a property of an individual group — which is where this puts it:One caveat, stated rather than glossed over: GitHub only parses
dependabot.ymlfrom the default branch, so no CI check on this pull request validates it. Schema validation is the strongest proof available pre-merge. After merge, the Dependabot tab under Insights → Dependency graph reports a config error if one exists — worth a glance.Contract impact
None. Repository automation only; nothing in
src/, no effect on the published package.