docs: say which ci legs actually gate a merge - #47
Merged
Conversation
The merge rule claimed the Current leg was part of the gate. It is not: the ruleset requires the six LTS legs and lint-title, and Node Current runs alongside them as a signal. Leaving the two disagreeing means the next person to read the rule either believes a gate that does not exist, or adds one that should not. Keeping it advisory is the deliberate choice, so the reason is written down too: an upstream regression in a release nobody deploys yet should not block pull requests that have nothing to do with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drift
AGENTS.md said a merge requires green CI across the full matrix, "plus one leg on Current so that
engines: >=22is a claim something checks" — phrased as part of the gate.It is not part of the gate. The
mainruleset requires exactly:Node 26 / ubuntu-latestruns on every pull request and is not required. So the document described a gate the repository does not enforce.The change
Split the bullet in two and state the arrangement as it is: the six LTS legs plus
lint-titleare the gate; the Current leg is a signal you read before merging, and deliberately does not block.Documenting reality was the choice here rather than adding
Node 26to the required checks, and the reasoning is now in the file: Current tracks a release nobody deploys yet, so an upstream regression there would block every unrelated pull request in the repository. A red X you have to look at is the right amount of pressure for that; a locked merge button is not.Anyone who later disagrees can add the check — but they will be changing a decision that is written down, instead of repairing a contradiction.
What was checked
README.md needed no change: it already says CI "runs" those legs and never claimed the Current one gates anything.
Contract impact
None — repository process documentation. No
src/change, no effect on the published package, andstrict_required_status_checks_policystaysfalse, so this pull request and the other open ones still merge in any order.