Skip to content

[TM ONLY] Evil string operator overloading for guestbook behavoir #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FalloutFalcon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[TM ONLY] Evil string operator overloading for guestbook behavoir #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94e97aa
theory crafting
FalloutFalcon Sep 15, 2026
4d3b44c
tweak
FalloutFalcon Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/__DEFINES/~darkpack/guestbook.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
#define GUESTBOOK_FORGETMENOT (1 << 3)

/// Differs from GET_GUESTBOOK_NAME_TRUE as it returns the known name OR the whole mob for situations where we directly embed into a string for text macros.
#define GET_GUESTBOOK_NAME(mob, guest) (mob?.mind?.guestbook?.get_known_name(mob, guest) || guest)
#define GET_GUESTBOOK_NAME(mob, guest) (mob?.mind?.guestbook?.get_known_name(mob, guest) || guest.name)
/// Macro to get a STRING (never a mob) of the name we refer to them as.
#define GET_GUESTBOOK_NAME_TRUE(mob, guest) (mob?.mind?.guestbook?.get_known_name(mob, guest) || guest.name)
2 changes: 1 addition & 1 deletion code/__HELPERS/stack_trace.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
/// Returns an ordered list of all our parent procs, highest to deepest.
///
/// introspection like this is mostly useful for debugging, if you have another use I suspect you are just creating god's strongest footgun and should rethink things
/proc/dump_stack(max_depth = STACK_DEPTH_SEARCH_LIMIT)
/proc/dump_stack(max_depth = STACK_DEPTH_SEARCH_LIMIT) as /list // DARKPACK EDIT CHANGE
var/list/proc_paths = list()
var/crashed = FALSE
var/depth = 0
Expand Down
12 changes: 12 additions & 0 deletions modular_darkpack/modules/guestbook/code/human_helpers.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,15 @@
if(prefixed)
final_string = "\A [final_string]"
return lowercase ? LOWER_TEXT(final_string) : final_string

GLOBAL_LIST_EMPTY(living_ref_stacktraces)
/mob/living/proc/operator""()
var/dump = jointext(dump_stack(1), ": ")
if(GLOB.living_ref_stacktraces[dump])
GLOB.living_ref_stacktraces[dump]++
else
GLOB.living_ref_stacktraces[dump] = 1
sortTim(GLOB.living_ref_stacktraces, GLOBAL_PROC_REF(cmp_numeric_dsc), associative = TRUE)
logger.Log(LOG_CATEGORY_DEBUG, "Operator Test: [dump]")
return usr?.mind?.guestbook?.get_known_name(usr, src) || name

Loading