Fix SpectraMax kinetic time parsing when edge wells are skipped - #172
Merged
Conversation
SoftMax Pro writes elapsed time on the first populated row, so unselected row A left every reading with a null time and hid the plate-map slider. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When edge wells are unselected, SoftMax still exports a full 8×12 grid but leaves those cells empty and puts elapsed time/temperature on the first populated row (here, B), not A. The grid parser only read time/temp at row_idx == 0, so every well got a null time and the UI hid the kinetic slider despite measurement_type: Kinetic.
The new logic takes the first non-empty time/temp in each reading group, then attaches them to wells — correct for this fixture (time on B before B’s wells are recorded) and a no-op for normal full-plate kinetics (time still on A).
Changes
row_idx == 0, restoring the plate-map time slider for partial-plate kinetics.Test plan
uv run pytest lambda/tests/spectramax_plate_reader/ -quv run data-hub-process spectramaxon production files → 161 timepoints, no null timesMade with Cursor