Handle incomplete SoftMax kinetic exports in SpectraMax parser - #173
Merged
Conversation
…count. Also document that agents must not put internal-environment secrets or IDs into commits and PRs. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When SoftMax stops a Kinetic run early, the plate header’s
num_readingscan exceed the exported groups. The old loop kept consuming the summary (or hit~Endbadly). The new path:~End/ EOF (_at_plate_end)_kinetic_reading_present+_ELAPSED_TIME_RE, includingD.HH:MM:SS)Applied in both flat and grid layouts. Tests cover overstated count + summary, day-prefixed times, and stop-at-
~Endwithout summary.AGENTS.mdadds a no-internal-secrets-in-PRs rule (sensible; slightly orthogonal to the parser fix).Changes
~Endinstead of raisingIndexError.num_readings, including day-prefixed elapsed times after 24 h (D.HH:MM:SS).AGENTS.mdthat agents must not put internal-environment secrets, signed URLs, or instrument/run/file IDs into commits or PRs.Test plan
uv run pytest lambda/tests/spectramax_plate_reader/test_parse_raw_well_data.py -qMade with Cursor