Add optional group name to DeathLinkService#138
Open
nickdavies wants to merge 1 commit into
Open
Conversation
The "DeathLink" connection tag was hardcoded in send, receive-filter, enable, and disable,
so clients could not participate in Grouped DeathLink (per-group death pools).
Add an optional group name, exposed via a new CreateDeathLinkService(session, group) overload, that suffixes the tag ("DeathLink" + group).
A null or empty group leaves the tag exactly "DeathLink", so existing clients and the default pool are backward compatible. The existing no-arg overload and all public method signatures are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "DeathLink" connection tag is hardcoded in send, receive-filter, enable, and disable, so world builders could not participate easily participate in in Grouped DeathLink (per-group death pools). Eg DeadCells Custom world switched to making their own. Add an optional group name, exposed via a new
CreateDeathLinkService(session, group)overload, that suffixes the tag("DeathLink" + group).A
nullor empty group leaves the tag exactly"DeathLink", so existing clients and the default pool are backward compatible. The existing no-arg overload and all public method signatures are untouched.Let me know if this isn't a feature you want to make mainline but I was hoping to use this in KSP 1. If you are happy with this approach I can test it out on my custom world before merging
NOTE: I did use AI to generate the test cases but I read them and they seem reasonable.