fix(webhooks): wire API key scope enforcement for webhook routes - #1756
Merged
Olowodarey merged 1 commit intoAug 27, 2026
Merged
Conversation
WebhooksController is guarded by ApiKeyGuard, but WebhooksModule never imported AuthModule (which exports ApiKeyService) nor registered the guard as a provider. As a result the guard could not be resolved at runtime and per-route API-key scope checks were not enforced on the webhook endpoints. - Import AuthModule into WebhooksModule - Register ApiKeyGuard as a provider Adds route-level integration tests proving an in-scope key is allowed and an out-of-scope key receives 403 with the missing scope.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@abimbolaalabi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes per-endpoint API Key Scope Enforcement for the webhook routes. The ApiKeyGuard (which validates the presented X-API-Key and rejects requests whose key lacks a required route scope with 403) was never wired into the webhooks module, so a limited key could bypass scope checks on webhooks endpoints.
Related Issue
Closes #1639
Changes
Verification Results
\
pnpm run test # 112 suites / 1409 tests passed
pnpm run build # passed
eslint changed files # 0 errors, 0 warnings
\\
Acceptance Criteria