Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

fix: Fixing phoenix to ax notebook#124

Open
jimbobbennett wants to merge 2 commits intomainfrom
fix/fixing-phoenix-to-ax-notebook
Open

fix: Fixing phoenix to ax notebook#124
jimbobbennett wants to merge 2 commits intomainfrom
fix/fixing-phoenix-to-ax-notebook

Conversation

@jimbobbennett
Copy link
Copy Markdown

The Phoenix to AX notebook referenced by https://arize.com/docs/ax/security-and-settings/send-traces-from-phoenix-greater-than-arize doesn't work as it uses an out of date SDK.

This change makes it work.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Copy Markdown

@seldo seldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +403 to +420
" .reset_index()\n",
" .rename(\n",
" columns={\n",
" \"span_id\": \"context.span_id\",\n",
" \"result.label\": \"eval.Correctness.label\",\n",
" \"result.score\": \"eval.Correctness.score\",\n",
" \"result.explanation\": \"eval.Correctness.explanation\",\n",
" }\n",
" )\n",
" .set_index(\"context.span_id\")[\n",
" [\n",
" \"eval.Correctness.label\",\n",
" \"eval.Correctness.score\",\n",
" \"eval.Correctness.explanation\",\n",
" ]\n",
" ]\n",
")\n",
"\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely out of curiosity, why was all this verbosity not previously required?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 Not sure if it is a v7 vs v8 sdk thing, or a server side thing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants