Importer for auto set deck and removal of cards + lore fixes + message order - #5383
Open
Stabar-ti wants to merge 24 commits into
Open
Importer for auto set deck and removal of cards + lore fixes + message order#5383Stabar-ti wants to merge 24 commits into
Stabar-ti wants to merge 24 commits into
Conversation
Stabar-ti
marked this pull request as draft
July 10, 2026 21:35
Stabar-ti
marked this pull request as ready for review
July 10, 2026 21:36
Stabar-ti
marked this pull request as draft
July 11, 2026 09:02
Stabar-ti
marked this pull request as ready for review
July 11, 2026 09:03
Stabar-ti
marked this pull request as draft
July 12, 2026 07:46
Stabar-ti
marked this pull request as ready for review
July 12, 2026 07:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was created with minimal impact in mind. both resources and otherwise.
3 things:
a. This submision allows the upload of a json (guarded against weird stuff) to set all decks automatically (essentially a save file) and then also is able to remove certain cards from the decks. Creating a versatile tool with removing the necessaty to add custom decks for mid size changes.
files:
Possible Impact -> low
Run time -> low
passed all tests locally also tested extensively on local bot
b. This is two small lore fixes
files
zero danger for standard games
c. Bug fix for message order. as discussed with Fin
just changes the order to be correct.
main file impacted:
TacticalActionButtonHelpers
Impact minimal
TESTS:
This branch was tested with mvn (2 weeks ago last time) locally
All tests passed
Tested against local and fog games for errors and potential leaks.