Skip to content

enhance oflm test so it actually catches things? #76

Description

@Cyronius

Should we add better tests to oflm test so that it actually catches things? The ones inherited from flm never catch anything.

A few from the last two weeks:

Asking for a model that doesn't exist got you a different model's answer, with the name you asked for echoed back (#52)
Every error response came back as HTTP 200 with a JSON parser message as the body, so the real error text never reached a client (#52)
Every document sent to /v1/embeddings was embedded as a query. Right shape, right length, deterministic, wrong (#52)
An answer cut off at max_tokens said it had finished normally (#52)
Every tool result arrived four tokens short, so a ticket code came back missing its last character and 18 degrees was reported as 15 (#59)
One client asking for low reasoning effort turned thinking on for everybody else (#59)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions