Skip to content

oflm-add: --system-list is accepted but ignored #82

Description

@D-revv

Summary

oflm-add fails with "Could not locate the system model_list.json (looked next to oflm and in /opt,/usr,/usr/local share/oflm). Pass --system-list." even when --system-list <path> is passed.

Cause

In utilities/oflm-add/oflm_add/__init__.py:

  • argparse defines --system-list
  • find_system_model_list() takes no argument and only checks the oflm-adjacent candidate plus the fixed paths; it is called bare (system_list = find_system_model_list()), so the parsed args.system_list value is never consulted.

Repro

Any environment where the auto-detect candidates are absent (e.g. running from a build tree):

oflm-add /path/to/model-dir --tag foo:2b --family llama3 --system-list /path/to/src/model_list.json
# -> Could not locate the system model_list.json … Pass --system-list.

Workaround that worked

Place a copy of model_list.json next to an oflm entry on PATH (that is the first auto-detect candidate), e.g. ln -s <build>/src/oflm /usr/local/bin/oflm && cp src/model_list.json /usr/local/bin/.

Suggested fix

system_list = Path(args.system_list) if args.system_list else find_system_model_list() — or thread the argument into the finder.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions