feat: resolve issues #835 #836 #837 #838 - #940
Open
ahmadrabiumustapha wants to merge 1 commit into
Open
Conversation
AtomicIP#835 – multi_currency.rs: add fee-asset consistency policy - Add fee_asset field to MultiCurrencyConfig (defaults to XLM) - Add FeeAssetValidation enum and validate_fee_asset() method - Add FeeCalculation struct and collect_fee() method — fees are always denominated in fee_asset regardless of settlement token - Add tests for XLM, USDC, and EURC settlement currencies plus zero-amount and policy-coverage tests AtomicIP#836 – rollback_tests.rs: multi-currency and cross-contract coverage - Add multi-currency rollback tests: USDC-like refund, RolledBack status, EURC after-window rejection, two-currency independence - Add cross-contract rollback tests: ip_registry intact after rollback, no funds stuck in contract, IP record stays consistent, IP can be reused immediately after rollback AtomicIP#837 – registry.rs / architecture.md: document role and relationship - Add module-level doc comment to registry.rs explaining it is a local read-only proxy for ip_registry (not a standalone registry) - Add 'registry.rs — Local Registry Helper' section to docs/architecture.md with ASCII relationship diagram and table AtomicIP#838 – handlers.rs: wire commit_ip to Soroban RPC - Add api-server/src/soroban_rpc.rs with SorobanRpcClient trait, LiveSorobanRpcClient (reqwest + env vars), MockSorobanRpcClient, and map_rpc_error_to_status() (400 / 404 / 503 / 500) - Wire commit_ip handler to SOROBAN_CLIENT Lazy static; remove TODO - Add 503 response code to utoipa path docs - Register soroban_rpc module in main.rs and lib.rs - Add commit_ip integration tests in integration_tests.rs chore: update .gitignore - Exclude test_snapshots, __snapshots__, jest coverage, fuzz queue/hangs, node_modules, *.wasm, deployment artefacts, api-server/Cargo.lock, .stellar/, log/tmp files, vrickish.md
|
@ahmadrabiumustapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#835 – multi_currency.rs: add fee-asset consistency policy
#836 – rollback_tests.rs: multi-currency and cross-contract coverage
#837 – registry.rs / architecture.md: document role and relationship
#838 – handlers.rs: wire commit_ip to Soroban RPC
chore: update .gitignore
registry.rsrole and its relationship toip_registry#837commit_iphandler to the actual Soroban RPC call #838