fix(#831-#834): staleness boundary tests, full lifecycle cross-contra… - #942
Open
ahmadadebayo78-boop wants to merge 1 commit into
Conversation
…cle cross-contract tests, upgrade schema tests AtomicIP#834: Add exactly-at-threshold (300s) and just-past-threshold (301s) staleness tests to oracle_tests.rs, covering both get_oracle_price and initiate_swap_with_oracle_price. Documents and locks the <= boundary in fetch_oracle_price_with_staleness_check. AtomicIP#833: Add full-lifecycle cross-contract integration tests to cross_contract_tests.rs. Covers commit->initiate->accept->reveal->Completed, revoked IP rejection (IpRevoked), ownership-unchanged assertion after swap completion, and sequential swaps on the same IP after lock release. AtomicIP#832: Uncomment and fix the broken upgrade schema test module in upgrade.rs. The entire #[cfg(test)] mod tests block was commented out and one test was dangling outside any module. Replaced with a proper live 14-test module covering valid upgrades, additive changes, version gate, missing/changed function/error/storage-key rejections, schema round-trip, and absence. AtomicIP#831: Verified already fully implemented (no code changes needed). initialize() rejects zero/placeholder treasury with InvalidTreasury, tests exist in lib.rs, and both deploy scripts validate TREASURY_ADDRESS.
|
@ahmadadebayo78-boop Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ct tests, upgrade schema tests
#834: Add exactly-at-threshold (300s) and just-past-threshold (301s) staleness tests to oracle_tests.rs, covering both get_oracle_price and initiate_swap_with_oracle_price. Documents and locks the <= boundary in fetch_oracle_price_with_staleness_check.
#833: Add full-lifecycle cross-contract integration tests to cross_contract_tests.rs. Covers commit->initiate->accept->reveal->Completed, revoked IP rejection (IpRevoked), ownership-unchanged assertion after swap completion, and sequential swaps on the same IP after lock release.
#832: Uncomment and fix the broken upgrade schema test module in upgrade.rs. The entire #[cfg(test)] mod tests block was commented out and one test was dangling outside any module. Replaced with a proper live 14-test module covering valid upgrades, additive changes, version gate, missing/changed function/error/storage-key rejections, schema round-trip, and absence.
#831: Verified already fully implemented (no code changes needed). initialize() rejects zero/placeholder treasury with InvalidTreasury, tests exist in lib.rs, and both deploy scripts validate TREASURY_ADDRESS.
closes #831
closes #832
closes #833
closes #834