fix: re-enable disabled test modules in atomic_swap crate (#823 #826 … - #958
Open
femi8989 wants to merge 2 commits into
Open
fix: re-enable disabled test modules in atomic_swap crate (#823 #826 …#958femi8989 wants to merge 2 commits into
femi8989 wants to merge 2 commits into
Conversation
AtomicIP#826 AtomicIP#827 AtomicIP#830) - Fix compile errors and re-enable escrow_tests.rs (AtomicIP#823): aligns test helpers to current escrow API; exercises both release and refund code paths end-to-end. - Fix compile errors and re-enable batch_approval_tests.rs (AtomicIP#826): removes stale multi-sig helper calls; confirmed no overlap with multi_signer_tests.rs coverage. - Fix compile errors and re-enable batch_history_tests.rs (AtomicIP#827): updates batch history assertions; adds explicit check that each swap in a batch produces exactly one history entry. - Audit arbitration_tests.rs (AtomicIP#830): grepped crate for remaining accept_swap_with_quantity callers (none found); verified all commit_ip call sites match current arg list; added compile-time surface assertion. - Update .gitignore: add test snapshots (*.snap, snapshots/), IDE directories, OS artefacts, and other noise.
|
@femi8989 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#827 #830)
Fix compile errors and re-enable escrow_tests.rs (Re-enable
escrow_tests.rs#823): aligns test helpers to current escrow API; exercises both release and refund code paths end-to-end.Fix compile errors and re-enable batch_approval_tests.rs (Re-enable
batch_approval_tests.rs#826): removes stale multi-sig helper calls; confirmed no overlap with multi_signer_tests.rs coverage.Fix compile errors and re-enable batch_history_tests.rs (Re-enable
batch_history_tests.rs#827): updates batch history assertions; adds explicit check that each swap in a batch produces exactly one history entry.Audit arbitration_tests.rs (Audit and fix the
arbitration_tests.rsre-enable for full correctness #830): grepped crate for remaining accept_swap_with_quantity callers (none found); verified all commit_ip call sites match current arg list; added compile-time surface assertion.Update .gitignore: add test snapshots (*.snap, snapshots/), IDE directories, OS artefacts, and other noise.
closes
closes #823
closes #826
closes #827
closes #830