Conversation
…update dependencies
…and adjust scaling argument
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new WSA-ENLIL NOAA client to the NoaaClient package that downloads the WSA-ENLIL animation manifest + frames and encodes them into an MP4 (H.264) using FFmpeg (via FFMpegCore), with DI registration and sample/docs updates.
Changes:
- Introduces
IWsaEnlilClient+WsaEnlilClientand the manifest response model, including frame download + MP4 encoding. - Wires the client into DI and extends docs + sample app to demonstrate producing/saving MP4 animations.
- Adds unit tests for empty-manifest behavior and cancellation handling.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/UnitTests/NoaaClient/WsaEnlil/WsaEnlilClientTests.cs | Adds unit tests around empty manifest and cancellation scenarios for the new client. |
| src/NoaaClient/WsaEnlil/WsaEnlilClient.cs | Implements the WSA-ENLIL manifest download, frame download, temp-dir handling, and MP4 encoding pipeline. |
| src/NoaaClient/WsaEnlil/Responses/WsaEnlilManifestEntry.cs | Adds a JSON model for manifest entries (url). |
| src/NoaaClient/WsaEnlil/IWsaEnlilClient.cs | Defines the public interface contract + XML docs for the new client. |
| src/NoaaClient/ServiceCollectionExtensions.cs | Registers IWsaEnlilClient with AddHttpClient. |
| src/NoaaClient/README.md | Documents WSA-ENLIL usage and encoder characteristics. |
| src/NoaaClient/NoaaClient.csproj | Adds the FFMpegCore package dependency to support encoding. |
| samples/NoaaClientSample/Program.cs | Adds menu options and saving logic to fetch and persist WSA-ENLIL MP4 animations. |
| README.md | Updates top-level feature list and adds FFmpeg installation instructions. |
| Directory.Packages.props | Adds central package versions for FFMpegCore (and an additional package entry). |
| Directory.Build.props | Sets NuGet audit level and bumps package base version. |
| .gitignore | Ignores .serena/ files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…d corresponding tests
Demosfen
requested changes
Aug 7, 2026
Demosfen
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.