Skip to content

feat: collect bulk prediction outputs#95

Merged
vtnphan merged 2 commits into
mainfrom
sbp-368
Jul 3, 2026
Merged

feat: collect bulk prediction outputs#95
vtnphan merged 2 commits into
mainfrom
sbp-368

Conversation

@vtnphan

@vtnphan vtnphan commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

SBP-368 Adds output collection and score extraction for WISPS bulk prediction workflows (boltz, colabfold), and adds targeted tests to bring CI test coverage above the 90% threshold.

Changes

  • app/services/results_utils.py — adds extract_bulk_prediction_max_score (reads PTM scores from S3 CSV) and _make_bulk_prediction_spec, registers bulk-prediction output specs for boltz and colabfold tools
  • tests/test_routes_results.py — 5 new tests covering queued-job launch_payload overlay, YAML parse fallback, and get_result_download_all 404/S3 error paths
  • tests/test_services_job_utils.py — 2 new tests covering null seqera_run_id skip and ValueError branch in ensure_completed_run_score
Screenshot 2026-07-03 at 12 08 51 pm Screenshot 2026-07-03 at 12 08 45 pm

How to Test

uv run pytest --cov=app --cov-report=term-missing -q
# Expected: all tests pass, coverage ≥ 90%

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added or updated documentation where necessary
  • I have run linting and unit tests locally
  • The code follows the project's style guidelines

@vtnphan vtnphan marked this pull request as ready for review July 3, 2026 02:07
@vtnphan vtnphan requested a review from amandazhuyilan July 3, 2026 02:09

@amandazhuyilan amandazhuyilan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good lets go

@vtnphan vtnphan merged commit 9624571 into main Jul 3, 2026
2 checks passed
@vtnphan vtnphan deleted the sbp-368 branch July 3, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants