Conversation
amandazhuyilan
approved these changes
Jul 3, 2026
amandazhuyilan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good lets go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-368 Adds output collection and score extraction for WISPS bulk prediction workflows (boltz, colabfold), and adds targeted tests to bring CI test coverage above the 90% threshold.
Changes
app/services/results_utils.py— addsextract_bulk_prediction_max_score(reads PTM scores from S3 CSV) and_make_bulk_prediction_spec, registers bulk-prediction output specs forboltzandcolabfoldtoolstests/test_routes_results.py— 5 new tests covering queued-joblaunch_payloadoverlay, YAML parse fallback, andget_result_download_all404/S3 error pathstests/test_services_job_utils.py— 2 new tests covering nullseqera_run_idskip andValueErrorbranch inensure_completed_run_scoreHow to Test
uv run pytest --cov=app --cov-report=term-missing -q # Expected: all tests pass, coverage ≥ 90%Type of change
Checklist