feat: flag unidiomatic overuse of "highly" - #4055
Open
hippietrail wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I keep seeing "highly" used as a general intensifier like "very" in all kinds of places it didn't used to be used. I made a linter for the specific case of "highly kept secret" some months ago. This linter is more general.
It includes a check against words that do commonly collocate with "highly". Any others will be flagged with "very" requested as a replacement. A second list has specific replacements for specific words.
I went back and forth with an AI on which words to include or not, starting with all instances of "highly" in my corpus of READMEs from GitHub.
How Has This Been Tested?
cargo testAI Disclosure
I mostly used AI for going over the word lists but I also got it to make my linter code more Rusty once my hand-coded version worked as I wanted it to.
If Your PR Implements or Enhances a Linter
Checklist