Data migration to delete appdata-v1.deprecated.json and related cruft#3685
Open
fredrikekelund wants to merge 3 commits into
Open
Data migration to delete appdata-v1.deprecated.json and related cruft#3685fredrikekelund wants to merge 3 commits into
appdata-v1.deprecated.json and related cruft#3685fredrikekelund wants to merge 3 commits into
Conversation
In #2793 and related PRs, we copied `appdata-v1.json` into three decoupled config files in `~/.studio`. We also copied the `server-files` and `certificates` directories to `~/.studio`. The migration went off smoothly. This new migration removes the original paths from the user's system.
Collaborator
📊 Performance Test ResultsComparing 6d90baf vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
bcotrim
reviewed
Jun 3, 2026
Contributor
bcotrim
left a comment
bcotrim
left a comment
There was a problem hiding this comment.
appdata-v1.json is only renamed to appdata-v1.deprecated.json after the split-config migration completes. If that migration fails before the rename, this cleanup would delete the raw legacy config on the next launch, potentially removing the only recoverable source data.
Should we only delete appdata-v1.deprecated.json?
Contributor
Author
|
@bcotrim, good call 👍 Thanks for staying alert. I changed the migration condition to only run if |
fredrikekelund
changed the title
appdata-v1.json and related cruftappdata-v1.deprecated.json and related cruft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude did the implementation over two passes, using a detailed spec from me.
Proposed Changes
In #2793 and related PRs, we copied
appdata-v1.jsoninto three decoupled config files in~/.studio. We also copied theserver-filesandcertificatesdirectories to~/.studio.The migration went off smoothly. This PR adds a new migration that removes the original paths from the user's system.
Testing Instructions
open ~/Library/Application\ Support/Studioin a terminal.appdata-v1.deprecated.jsonfile, aserver-filesdirectory, or acertificatesdirectory. If not, create an emptyserver-filesdirectory.npm start.appdata-v1.deprecated.json,server-files, andcertificatesare all removed.Pre-merge Checklist