Skip to content

fix(dev-env): restore update wizard prompts#2852

Merged
sjinks merged 1 commit into
trunkfrom
pltfrm-2426-vip-cli-vip-dev-env-update-not-prompting-wizard
Jun 3, 2026
Merged

fix(dev-env): restore update wizard prompts#2852
sjinks merged 1 commit into
trunkfrom
pltfrm-2426-vip-cli-vip-dev-env-update-not-prompting-wizard

Conversation

@sjinks
Copy link
Copy Markdown
Member

@sjinks sjinks commented May 23, 2026

Description

Fixes a regression where vip dev-env update stopped showing the wizard in interactive sessions.

The update flow was globally suppressing prompts based on broad option/config detection. This change makes suppression depend on TTY mode, so interactive sessions keep the wizard while non-interactive sessions remain non-interactive.

Linear: https://linear.app/a8c/issue/PLTFRM-2426/vip-cli-vip-dev-env-update-not-prompting-wizard

Changelog Description

Fixed

  • Fixed a regression where vip dev-env update could skip wizard prompts in interactive sessions.
  • Restored expected interactive behavior while preserving non-interactive behavior for non-TTY execution.

Pull request checklist

New release checklist

Steps to Test

  1. Check out this PR branch.
  2. Run npm ci.
  3. Run npm run jest -- --runTestsByPath __tests__/bin/vip-dev-env-update.js.
  4. Run npm run check-types.
  5. In interactive TTY, run vip dev-env update --slug <slug> and confirm wizard prompts are shown.
  6. In non-TTY context, run the same command and confirm prompts are suppressed/non-interactive.

Copilot AI review requested due to automatic review settings May 23, 2026 10:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@sjinks sjinks self-assigned this May 23, 2026
@sjinks sjinks requested a review from Copilot May 23, 2026 10:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@sjinks sjinks added [Status] Needs Review [Type] Bug Something isn't working labels May 23, 2026
@sjinks sjinks force-pushed the pltfrm-2426-vip-cli-vip-dev-env-update-not-prompting-wizard branch from e54c333 to 998b5b6 Compare May 23, 2026 10:14
@sjinks sjinks requested a review from a team May 23, 2026 10:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 23, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sjinks sjinks force-pushed the pltfrm-2426-vip-cli-vip-dev-env-update-not-prompting-wizard branch 2 times, most recently from 02bcae1 to 51ab4f4 Compare May 23, 2026 11:26
#### Purpose and Context

The update wizard stopped prompting in interactive sessions because
prompt suppression was triggered by broad option detection. Metadata
and config-derived objects were treated like explicit CLI selections,
which suppressed prompts globally.

#### Key Changes

- Changed suppression logic in vip dev-env update to suppress prompts
  only when stdin is non-TTY.
- Removed broad option-count suppression that treated unrelated option
  metadata as explicit configuration.
- Added a focused bin test suite for vip dev-env update prompt behavior
  in interactive and non-interactive modes.
- Added coverage for partial interactive options to ensure provided
  values are preselected while remaining prompts are still shown.

#### Impact and Considerations

Interactive TTY flows now continue to show the wizard unless running in
non-interactive mode. Partial options still prefill selected values,
and non-TTY behavior remains fully non-interactive.

#### Testing and Validation

- Ran npm ci in the isolated worktree.
- Ran focused Jest regression tests for vip dev-env update suppression.
- Ran TypeScript type checking.

Refs: PLTFRM-2426
@sjinks sjinks force-pushed the pltfrm-2426-vip-cli-vip-dev-env-update-not-prompting-wizard branch from 51ab4f4 to 028c7ef Compare May 29, 2026 15:53
@sonarqubecloud
Copy link
Copy Markdown

@sjinks sjinks merged commit 73357db into trunk Jun 3, 2026
19 checks passed
@sjinks sjinks deleted the pltfrm-2426-vip-cli-vip-dev-env-update-not-prompting-wizard branch June 3, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants