test(cli): cover wp parser invocation matrix#2858
Open
sjinks wants to merge 1 commit into
Open
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds focused Jest coverage for vip wp parser/dispatch behavior, ensuring VIP CLI options, aliases, separators, and WP-CLI payload arguments are forwarded as expected.
Changes:
- Adds a new parser invocation matrix for successful
vip wpdispatch scenarios. - Adds a negative test for WP command payloads missing the required
--separator.
## Purpose and Context PLTFRM-2355 calls for parser coverage around `vip wp` invocations after option handling proved fragile across aliases and `--` separator placement. ## Key Changes - Add coverage for option-only `wp` invocations. - Cover alias forwarding and separator-preserved payload forwarding. - Assert the missing-separator error for real `wp` payloads. ## Impact and Considerations This is test-only and does not change CLI runtime behavior. ## Testing and Validation Ran `npx jest __tests__/lib/cli/command-wp-matrix.test.js --color`. Ran `npx jest __tests__/lib/cli/command.js --color`. Refs PLTFRM-2355
sjinks
force-pushed
the
pltfrm-2355-add-parser-invocation-matrix-test-file-covering-alias
branch
from
33bb176 to
b69cc03
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds parser invocation coverage for
vip wpargument forwarding across aliases,--separators, option-only calls, and payload calls. This guards the expected split between VIP CLI options and WP-CLI payload arguments.Refs: PLTFRM-2355
Changelog Description
No customer-facing changes; test coverage only.
Pull request checklist
New release checklist
Steps to Test
npx jest __tests__/lib/cli/command-wp-matrix.test.js --color.npx jest __tests__/lib/cli/command.js --color.