media: add opt-in Apple Music animated album covers#2918
Open
FormalSnake wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plays an album's animated Apple Music cover over the static circle art in the media player, looping and muted. Falls back to the static cover whenever there's no video, the fetch fails, QtMultimedia is missing, or playback is paused.
Off by default. When enabled it resolves the cover via the iTunes Search API, an anonymous web-player token scraped from music.apple.com's JS bundle, and the
editorialVideofield fromamp-api. This is Apple's private web API, the same token any browser gets, but nothing stops them changing it. Only merge if depending on that is fine for the project.The mp4 is downloaded once to
~/.cache/DankMaterialShell/applemusic-art/(the ffmpeg backend truncates the HLS stream on some setups) via a temp file and atomic rename, cached per album including misses, and pruned after 30 days. The toggle notes that the playing artist and album are sent to Apple; with it off there are zero requests.