Adds support for factory provisioned signing - #519
Merged
Conversation
When factory provisioned keys will be used, Signed Video will use the ONVIF Media Signing format for H.264 and H.265. For AV1 it will still use the same factory provisioned key, but within the signed video framework. Therefore, the normal attestation procedure is updated to also work with certificates including the public key. Varification can now also handle multiple trusted CAs, which is necessary since the factory provisioned keys will have different CAs. The tests have been updated with a new certificate chain including an intermediate certificate.
bjornvolcker
requested review from
Caroline-Holmstrom,
lusikamalo2 and
mithydolphin
as code owners
June 30, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When factory provisioned keys will be used, Signed Video
will use the ONVIF Media Signing format for H.264 and
H.265. For AV1 it will still use the same factory
provisioned key, but within the signed video framework.
Therefore, the normal attestation procedure is updated
to also work with certificates including the public key.
Varification can now also handle multiple trusted CAs,
which is necessary since the factory provisioned keys
will have different CAs.
The tests have been updated with a new certificate chain
including an intermediate certificate.