feat: add Intel Mac (x86_64) DMG build support - #24
Open
AzimovS wants to merge 4 commits into
Open
Conversation
- Split whisper-rs macOS deps by architecture: Metal+CoreML for Apple Silicon, CPU-only for Intel (Metal Family 7 unsupported by whisper.cpp) - Fix whisper_engine.rs GPU detection to return false on x86_64 - Fix build.rs to report correct GPU status per architecture - Update lib.rs debug updater check for darwin-x86_64 - Add x86_64-apple-darwin matrix entry to release.yml - Add latest.json merge step to prevent overwrite race between builds - Update build.yml: use matrix target instead of hardcoded aarch64, add target to FFmpeg cache key, set CMAKE_OSX_ARCHITECTURES for cross-compilation - Update build-macos.yml with target architecture selector input Locally verified: full release build cross-compiles successfully, binary confirmed x86_64 via file/lipo, correct whisper-rs features resolved per architecture, YAML syntax validated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
llama-helper's llama.cpp doesn't cross-compile from ARM64 to x86_64 without additional cmake configuration. Since the sidecar is already skipped for signed macOS builds (not needed yet), apply the same treatment to Intel builds: skip sidecar build and strip externalBin from tauri.conf.json. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Code reviewFound 3 issues:
meetily/.github/workflows/release.yml Lines 173 to 178 in d8c0fce
meetily/.github/workflows/release.yml Lines 179 to 195 in d8c0fce
meetily/.github/workflows/release.yml Line 174 in d8c0fce 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
…pulate signatures Three bugs fixed in the latest.json merge script: 1. Regex patterns now match actual tauri-action filenames (e.g. meetily_aarch64.app.tar.gz, not aarch64-apple-darwin...) 2. .sig files are downloaded and read into the signature field (previously found but never read, leaving signatures empty) 3. Removed dead baseUrl variable with typo Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Pass variables via process.env and files instead of shell interpolation into inline JS (eliminates injection vector) - Make empty signature fatal (exit 1) instead of warning - Validate all 4 expected platforms exist in merged latest.json - Remove explicit gh api DELETE before --clobber upload (--clobber handles replacement atomically, avoids availability gap) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latest.jsonmerge step so both macOS architectures appear in the auto-updater manifestTest plan
build-macos.ymlwith targetx86_64-apple-darwin, signing ON → verify signed DMG is producedrelease.ymllatest.jsoncontains bothdarwin-aarch64anddarwin-x86_64Local verification done
cargo build --release --target x86_64-apple-darwin) ✅file/lipo✅raw-apionly on x86_64,raw-api+metal+coremlon aarch64 ✅🤖 Generated with Claude Code