Port to 26.2 - #1290
Open
windy664 wants to merge 8 commits into
Open
Conversation
added 7 commits
July 4, 2026 11:38
…tion APIs - Dyes/concrete: Items.<COLOR>_DYE/CONCRETE/CONCRETE_POWDER -> Items.DYE/CONCRETE/CONCRETE_POWDER.pick(DyeColor.<COLOR>) - Copper: rewrite VanillaCompat copper section over WeatheringCopperCollection<Item> - Remove one-shot MC probe workflow (sources resolved locally)
- Advancement criterion package: net.minecraft.advancements.criterion/.Criterion/.CriterionTrigger -> .triggers.* - Tag providers: TagAppender.add now takes ResourceKey (add k()/kb()/kf() helpers for Item/Block/Fluid) - MIVillagerTradesTagProvider: KeyTagProvider -> TagsProvider (KeyTagProvider removed) - Drop removed IntrinsicHolderTagsProvider import - PipeBlockEntity: net.minecraft.util.Tuple removed -> com.mojang.datafixers.util.Pair (getA/getB -> getFirst/getSecond)
Mechanical: - Remove leftover MultiBufferSource imports (7 files; real uses were already commented out) - Sheets.cutoutBlockSheet() -> cutoutBlockItemSheet() (BLOCKS-atlas cutout) - LevelRenderer.getLightCoords/BrightnessGetter -> net.minecraft.util.LightCoordsUtil - Minecraft.screen -> Minecraft.gui.screen() - LevelRenderer.allChanged() -> Minecraft.levelExtractor.allChanged() Removed/stubbed (immediate mode gone under Vulkan): - MIClient: drop dead RegisterRenderBuffersEvent listener + import (removed in NeoForge 26.2) - RenderHelper.renderVoxelShape: stub (ShapeRenderer removed; no live callers) - DeferredBarrelTextRenderer / MultiblockErrorHighlight: drop dormant immediate BufferSource field (render passes already disabled; restore via submit-node API later)
GuideME has no 26.2 build yet, so MI could not boot on 26.2. Downgrade it to an optional dependency so MI runs without it (in-game guidebook disabled until a 26.2 GuideME ships): - neoforge.mods.toml: guideme required -> optional - build.gradle: guideme implementation -> compileOnly (matches other optional deps) - MI.init: only call MIGuide.init() when guideme is loaded - GuideBookItem.use(): guard openGuide() behind a guideme-loaded check All touch points (MIGuide, GuideBookItem, MultiblockShapeCompiler) are now guarded/lazy.
Contributor
|
Hi, thanks for the PR. For the time being we are unlikely to port MI beyond 26.1, but we might reference this PR when the time to port to 27.1 comes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.