NFS diagnostics enhancements by bharathsm-ms · Pull Request #315 · Azure-Samples/azure-files-samples

bharathsm-ms · 2026-09-07T12:10:37Z

aznfs log + config collection (collect_aznfs_logs: stunnel share dir, aznfs data dir, azurefile-proxy journalctl/systemctl status)
aznfs stunnel port range capture in tcpdump (TCPDUMP_EXTRA_PORTRANGE, validate_tcpdump_portrange, -i any)
Configurable trace events via TraceEvents= (default nfs,nfs4)
Kernel logs captured at start (dmesg into nfs_dmesg during init) and appended at stop
Richer process state snapshot (ps stat/etime/wchan) replacing plain ps -ef

Applies 5 features from the nfsdiagupdates branch that were not in master: - aznfs log + config collection (collect_aznfs_logs: stunnel share dir, aznfs data dir, azurefile-proxy journalctl/systemctl status) - aznfs stunnel port range capture in tcpdump (TCPDUMP_EXTRA_PORTRANGE, validate_tcpdump_portrange, -i any) - Configurable trace events via TraceEvents=<csv> (default nfs,nfs4) - Kernel logs captured at start (dmesg into nfs_dmesg during init) and appended at stop - Richer process state snapshot (ps stat/etime/wchan) replacing plain ps -ef

microsoft-github-policy-service · 2026-09-07T13:38:12Z

bharathsm-ms please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copilot

🟡 Changes recommended

The updated diagnostics collection introduces security/operational risks (copying potentially sensitive stunnel data, clearing dmesg) and has a few correctness/performance gaps that should be addressed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR enhances the NFS diagnostics collection script to capture richer tracing and system state, with additional support for aznfs/stunnel-based deployments and improved kernel/process visibility during the capture window.

Changes:

Added configurable trace-cmd events via TraceEvents=<csv> (defaulting to nfs,nfs4).
Expanded network capture for aznfs scenarios (optional extra stunnel port range, -i any capture) and improved process-state snapshots.
Added kernel log capture at start (and append at stop), plus collection of aznfs-related directories and service logs.

File summaries

File	Description
`NfsDiagnostics/nfsclientlogs.sh`	Adds trace event configurability, aznfs/stunnel-aware network capture, kernel/process snapshots, and aznfs log/config collection.

Review details

Files reviewed: 1/1 changed files
Comments generated: 6
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+  if [ -d "${AZNFS_STUNNEL_SHARE_DIR}" ]; then
+    mkdir -p "${dest_dir}"
+    cp -a "${AZNFS_STUNNEL_SHARE_DIR}" "${dest_dir}/" 2>/dev/null || true
+  fi


+  # Capture existing kernel logs before starting the capture window
+  echo "======= dmesg at start =======" > "${DIRNAME}/nfs_dmesg"
+  dmesg -T >> "${DIRNAME}/nfs_dmesg" 2>&1 || true
+  dmesg -Tc > /dev/null


+  if [ "${start_port}" -gt "${end_port}" ]; then
+    return 1
+  fi


+  for arg in "$@"; do
+    case "$arg" in
+      TraceEvents=*) trace_events_csv="${arg#TraceEvents=}" ;;
+    esac
+  done


  else
    echo "Falling back to single-file tcpdump capture in ${DIRNAME} (no rotation)." >&2
-    nohup tcpdump -p -Z root -s "${TCPDUMP_SNAPLEN}" port ${NFS_PORT} -w "${DIRNAME}/nfs_traffic.pcap" &
+    nohup tcpdump "${tcpdump_iface[@]}" -p -Z root -s "${TCPDUMP_SNAPLEN}" "${tcpdump_filter[@]}" -w "${DIRNAME}/nfs_traffic.pcap" &


+  if [ -d "${AZNFS_DATA_DIR}" ]; then
+    mkdir -p "${dest_dir}"
+    cp -a "${AZNFS_DATA_DIR}" "${dest_dir}/" 2>/dev/null || true
+  fi


sprasad-microsoft

Looks good to me. Please review the copilot review comments, test it and merge.

sprasad-microsoft requested a lite review from Copilot September 7, 2026 13:38

Copilot started reviewing on behalf of sprasad-microsoft September 7, 2026 13:38 View session

Copilot AI reviewed Sep 7, 2026

View reviewed changes

sprasad-microsoft approved these changes Sep 8, 2026

View reviewed changes

Navigation Menu

NFS diagnostics enhancements - #315

NFS diagnostics enhancements #315
bharathsm-ms wants to merge 1 commit into
masterfrom
nfs_diag_updates

bharathsm-ms commented Sep 7, 2026

Uh oh!

microsoft-github-policy-service Bot commented Sep 7, 2026

Contribution License Agreement

Uh oh!

Copilot AI left a comment

Uh oh!

sprasad-microsoft left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bharathsm-ms commented Sep 7, 2026

Uh oh!

microsoft-github-policy-service Bot commented Sep 7, 2026

Contribution License Agreement

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

sprasad-microsoft left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants