Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects a misspelling of “InstanceID” in Azurite’s telemetry initialization logging and in the persisted telemetry instance ID config format.
Changes:
- Fixes
InstaceID→InstanceIDin telemetry startup log output. - Renames the persisted telemetry config JSON field from
instaceIDtoinstanceIDinGetInstanceID().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try{ | ||
| let data = fs.readFileSync(configFilePath, 'utf8'); | ||
| instaceID = JSON.parse(data.toString()).instaceID; | ||
| instanceID = JSON.parse(data.toString()).instanceID; | ||
| } | ||
| catch(e){ |
There was a problem hiding this comment.
GetInstanceID now reads/writes the JSON key instanceID, but existing installs may already have a config file written with the legacy misspelled key instaceID. With the current change, those users will fail to read the persisted ID, generate a new UUID, and overwrite the file, effectively changing the stable instance identity. Consider reading both keys (prefer instanceID, fallback to instaceID) and migrating the file to the corrected key when the legacy key is present.
There was a problem hiding this comment.
There's already logic to regenerate a missing instance ID, I figured that was sufficient
No description provided.