Skip to content

Document public release-note and generator evidence rules - #274

Merged
David Burg (daviburg) merged 3 commits into
mainfrom
docs/public-release-notes-and-generator-evidence
Sep 25, 2026
Merged

David Burg (daviburg) merged 3 commits into
mainfrom
docs/public-release-notes-and-generator-evidence

Conversation

@daviburg

Copy link
Copy Markdown
Member

Description

Capture review lessons from the typed-map and Zeptomail SDK PRs so public release notes remain consistent and generator evidence stays in reviewer-facing PR descriptions.

Changes

  • For new or edited public changelog and release-note entries, avoid internal BPM repository/PR links; keep generator commits and Swagger provenance in the PR description. Historical entries are out of scope.
  • Keep corresponding changelog and release-note entries aligned, and preserve multiline Markdown when creating or updating PR descriptions.
  • Test generated request wire contracts against the pinned Swagger operation's request schema, not similarly named response fields or only a mocked success.
  • Verify the exact generator commit is in BPM master; a merged generator PR does not include commits pushed to its branch afterward.

Testing

  • Focused instruction-content assertions passed.
  • git diff --check passed.
  • dotnet test not run: instructions-only change.

Checklist

  • Code follows repository conventions.
  • No generated clients or runtime files changed.
  • Documentation updated.
  • Changelog and release notes not changed: no user-facing SDK behavior changed.
  • Version not updated: not a release PR.

Prevent internal BPM links in new public release entries, keep mirrored release notes consistent, verify request wire fixtures and merged generator provenance, and preserve PR body formatting.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI balanced review requested due to automatic review settings September 25, 2026 19:15
@daviburg
David Burg (daviburg) requested a review from a team as a code owner September 25, 2026 19:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The instructions omit the documented workflow for updating existing PR descriptions.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Documents review practices for generated SDK validation, release notes, and PR descriptions.

Changes:

  • Adds request-schema and generator provenance guidance.
  • Adds public release-note consistency rules.
  • Documents multiline PR description handling.
File Description
.github/​copilot-instructions.md Adds generated-contract and release documentation guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/copilot-instructions.md Outdated
@daviburg David Burg (daviburg) self-assigned this Sep 25, 2026
Cover updates as well as creation with --body-file and read back the submitted PR body to catch flattened formatting.

Co-authored-by: Dobby <dobby@microsoft.com>
Copilot AI review requested due to automatic review settings September 25, 2026 20:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation changes are consistent, complete, and address the prior feedback.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Copilot AI review requested due to automatic review settings September 25, 2026 21:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation changes are complete, consistent, and address the prior feedback.

Review effort: Balanced
Findings: None

@daviburg
David Burg (daviburg) merged commit 5a6465e into main Sep 25, 2026
17 checks passed
@daviburg
David Burg (daviburg) deleted the docs/public-release-notes-and-generator-evidence branch September 25, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants