Skip to content

Integration test updates - #20

Merged
Elizabeth Maher (EMaher) merged 5 commits into
mainfrom
enewman/integration-test
Apr 29, 2026
Merged

Elizabeth Maher (EMaher) merged 5 commits into
mainfrom
enewman/integration-test

Conversation

@EMaher

Copy link
Copy Markdown
Contributor

Sync latest changes for integration testing including updates to resource path handling and API publisher.

@EMaher

Copy link
Copy Markdown
Contributor Author

Copilot fix the failing tests.

- Remove unnecessary type assertion in override-merger.ts
- Fix unknown type in template literals in product-publisher.ts
- Add yield* [] to generator without yield in api-product-extractor.test.ts
- Remove unused variable, fix eslint-disable directive, and rename unused param in extract-service.test.ts

Agent-Logs-Url: https://github.com/Azure/apiops-cli/sessions/e990f413-47fb-4e99-bddf-9c31ae9b68fe

Co-authored-by: EMaher <9244742+EMaher@users.noreply.github.com>

Copilot AI commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Copilot fix the failing tests.

Fixed in commit 6f28fc1. The CI was failing due to 7 lint errors across 4 files:

  • override-merger.ts: removed unnecessary as Record<string, unknown> type assertion
  • product-publisher.ts: wrapped error in String() to fix unknown type in template literals
  • api-product-extractor.test.ts: added yield* [] to generator function that had no yield statement
  • extract-service.test.ts: removed unused originalListResources variable, removed unused result variable, removed now-unnecessary eslint-disable-next-line require-yield comment, and renamed unused parent param to _parent

All 836 tests pass with no lint errors.

@EMaher

Copy link
Copy Markdown
Contributor Author

Copilot Should I add tests?

Copilot AI commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Copilot Should I add tests?

No new tests are needed for these changes — they were all lint fixes with no functional changes:

  • Removed an unnecessary type assertion
  • Wrapped error in String() for template literal compatibility
  • Added yield* [] to satisfy the generator syntax rule
  • Removed unused variables and renamed an unused parameter

The existing 836 tests already cover the underlying functionality.

@EMaher

Copy link
Copy Markdown
Contributor Author

related to #18

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EMaher
Elizabeth Maher (EMaher) merged commit 35ba909 into main Apr 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants