fix(extract): ignore Liquid expressions in named value discovery

[Junior (seilorjunior)]

This pull request refines how policy XML is scanned for dependencies, specifically improving the detection of named value references in the presence of Liquid template bodies. It introduces logic to ignore named value lookups inside <set-body template="liquid"> elements, ensuring only real dependencies are detected. Comprehensive tests are added to validate these changes and cover various edge cases.

Policy XML Parsing Improvements:

• Updated the scanPolicyReferences function in src/services/transitive-resolver.ts to exclude named value references found within Liquid template bodies, using new regular expressions and parsing logic to correctly handle nested and attribute-rich tags. [1] [2]

Test Coverage Enhancements:

• Added extensive unit tests in tests/unit/services/transitive-resolver.test.ts to verify that named values inside Liquid templates are ignored, while other dependencies (like backends and fragments) are still detected. These tests cover a wide range of policy XML patterns and edge cases.
• Introduced integration-style tests in tests/unit/services/extract-service.test.ts to ensure policies using Liquid templates are extracted without false dependency lookups or unintended policy modifications.Skip Liquid set-body content when discovering named values, while preserving ordinary policy references and original extracted artifacts. Handle CDATA, comments, nested body tags, and attribute variations. Add scanner and service/fragment extraction regression coverage.

Closes #276

[Copilot]

🟢 Approval recommended

The focused fix preserves other dependency scanning and includes comprehensive regression coverage.

Pull request overview

Prevents Liquid expressions from being misidentified as named-value dependencies during extraction.

Changes:

• Excludes Liquid set-body contents from named-value scanning.
• Adds scanner edge-case and extraction regression coverage.

File summaries

File	Description
src/services/transitive-resolver.ts	Skips Liquid bodies during named-value discovery.
tests/unit/services/transitive-resolver.test.ts	Covers Liquid parsing variants and boundaries.
tests/unit/services/extract-service.test.ts	Verifies successful extraction without false lookups or policy changes.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.