NetworkCloud CLI v5.0.1 - #10147
Merged
Merged
Conversation
… the API is made public.
idanielsteven
requested review from
Yu Chen (jsntcy),
Ethan Yang (necusjz),
ZelinWang (wangzelin007) and
Julie Zhu (yanzhudd)
as code owners
July 27, 2026 19:19
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the networkcloud Azure CLI extension to v5.0.1, primarily to support sending nullable cluster update properties as explicit null and to align generated command schemas/validators with that behavior.
Changes:
- Bump extension version to 5.0.1 and add release notes.
- Update cluster update argument/schema generation and pre-operation validators to support nullable object properties.
- Add a new scenario test + recording to validate
cluster updatewith nullable properties set tonull.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/networkcloud/setup.py | Bumps extension version to 5.0.1. |
| src/networkcloud/HISTORY.rst | Adds 5.0.1 release notes (contains a formatting typo to fix). |
| src/networkcloud/azext_networkcloud/tests/latest/test_cluster.py | Adds scenario13 test coverage for nullable cluster update properties (has a scenario helper mismatch to fix). |
| src/networkcloud/azext_networkcloud/tests/latest/recordings/test_cluster_scenario13.yaml | Adds recording for scenario13 nullable cluster update. |
| src/networkcloud/azext_networkcloud/operations/common_secretarchivesettings.py | Skips validation when secret-archive settings are explicitly set to null. |
| src/networkcloud/azext_networkcloud/operations/common_commandoutputsettings.py | Skips validation when command-output settings are explicitly set to null. |
| src/networkcloud/azext_networkcloud/operations/common_analyticsoutputsettings.py | Skips validation when analytics-output settings are explicitly set to null. |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/virtualmachine/_update.py | Removes password prompt behavior for VM image repository credentials (inconsistent with existing patterns). |
| src/networkcloud/azext_networkcloud/aaz/latest/networkcloud/cluster/_update.py | Marks multiple update properties as nullable in args and request schema. |
| src/index.json | Manual index edits included (should be reverted per repo guidance). |
| .l | Empty file present in PR (purpose unclear). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Collaborator
|
NetworkCloud |
Ethan Yang (necusjz)
approved these changes
Jul 28, 2026
Collaborator
|
[Release] Update index.json for extension [ networkcloud-5.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=174033888&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
NetworkCloud CLI v5.0.1
aaz: Azure/aaz#1050
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.